Don't allow lockfiles #71
Conversation
|
Ugh, yet another dotfile :( |
app/templates/gitignore
Outdated
| @@ -1,3 +1,6 @@ | |||
| node_modules<% if (nyc) { %> | |||
| .nyc_output | |||
| coverage<% } %> | |||
| yarn.lock | |||
| package-lock.json | |||
| npm-shrinkwrap.json | |||
There was a problem hiding this comment.
This one is not generated by default, so I don't see the point in ignoring it.
app/templates/gitignore
Outdated
| @@ -1,3 +1,6 @@ | |||
| node_modules<% if (nyc) { %> | |||
| .nyc_output | |||
| coverage<% } %> | |||
| yarn.lock | |||
| package-lock.json | |||
There was a problem hiding this comment.
You're already adding the npmrc file, so this is moot.
| @@ -1,3 +1,6 @@ | |||
| node_modules<% if (nyc) { %> | |||
| .nyc_output | |||
| coverage<% } %> | |||
| yarn.lock | |||
There was a problem hiding this comment.
Not sure I care enough to add this to be honest. I'll think about it.
There was a problem hiding this comment.
Even if I don't like yarn, I think it should be added so yarn users can contribute without switching tools or manually discard there lockfile
There was a problem hiding this comment.
I like neither yarn nor npm. It's just that I don't use yarn as it's been too unstable for me. I guess you're right though, should be included to prevent it accidentally included in PRs.
sindresorhus
changed the title
|
@sindresorhus hi Sindre, sorry to bother you here. maybe you wanna answer your reason on sindresorhus/ama#479? |
mastilver
force-pushed
the
no-lockfile-for-library
branch
from
26aa106
to
973587a
Compare
mastilver
force-pushed
the
no-lockfile-for-library
branch
from
973587a
to
d121474
Compare
|
Can't we set the |
We both know that is totally unrealistic… |
No description provided.