-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AbortController
#1511
Labels
enhancement
This change will extend Got features
future
The issue will be worked on in the future
✭ help wanted ✭
Comments
sindresorhus
added
enhancement
This change will extend Got features
✭ help wanted ✭
labels
Oct 22, 2020
👍 Maybe throw if the signal option is provided? That way we would avoid ambiguity. |
👍🏻 |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
This change will extend Got features
future
The issue will be worked on in the future
✭ help wanted ✭
Node.js 15 now supports
AbortController
and it makes sense for us to support it in Got. While I'm personally not a big fan of its overly verbose way of handling cancellation, it seems to become the de-facto way of handling cancellation going forward.I think we should still retain the current
.cancel()
method if possible.https://medium.com/@nodejs/node-js-v15-0-0-is-here-deb00750f278
https://developer.mozilla.org/en-US/docs/Web/API/AbortController
nodejs/node@8390f8a86b
The text was updated successfully, but these errors were encountered: