-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Request in exported types #1939
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
Request
class is exported as the default export fromsource/core/index
.In
source/index
, the types fromsource/core/index
are exported with an aggregation, like so:export * from 'source/core/index.js'
:got/source/index.ts
Line 19 in 49c605c
This re-export don't propagate the default export from
source/core/index.js
: https://developer.mozilla.org/en-US/docs/web/javascript/reference/statements/exportHence the
Request
type is lost in the re-export.It is not in the list of exported type: https:/sindresorhus/got/blob/main/documentation/typescript.md
So, I am not sure if this missing type is by design, or not. Feel free to close if this type is expected to be hidden.
Actual behavior
Expected behavior
Checklist
The text was updated successfully, but these errors were encountered: