Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to type-fest (devDependency) in provided types #2355

Closed
remko79 opened this issue Jun 6, 2024 · 0 comments
Closed

Reference to type-fest (devDependency) in provided types #2355

remko79 opened this issue Jun 6, 2024 · 0 comments

Comments

@remko79
Copy link

remko79 commented Jun 6, 2024

You are shipping types in the 'types.d.ts' where it has a reference to 'type-fest':

import type { Spread } from 'type-fest';

However, that's never installed when you just install 'got' as it's registered as a devDependency, thus it's not installed by default. Now I'm currently still on an outdated eslint version (v9 causes some issues) and that depends on globals, which depends on type-fest 0.xxx (outdated version) and that leads to the error i'm getting:

node_modules/got/dist/source/types.d.ts:3:15 - error TS2305: Module '"type-fest"' has no exported member 'Spread'.

3 import type { Spread } from 'type-fest';

Found 1 error in node_modules/got/dist/source/types.d.ts:3

Any way you can update it so it's not using types from another package or any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant