Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme example comment #1505

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Fix readme example comment #1505

merged 2 commits into from
Oct 19, 2020

Conversation

toondaey
Copy link
Contributor

@toondaey toondaey commented Oct 19, 2020 •
edited
Loading

This is just a documentation update to clarify that got.stream.delete also returns a stream.Writable. It doesn't include any new features or changes. Fixes #1504
example

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.

B'Tunde Aromire and others added 2 commits October 19, 2020 04:28
docs(stream): update documentation
1021d04 
States that `got.stream.delete` returns a writable to avoid misleading
users [example](https://runkit.com/toondaey/5f8cfa2149c7d7001a7ea34b)
@sindresorhus
Update readme.md
629d54f
@sindresorhus sindresorhus changed the title docs(stream): update documentation Fix readme example comment Oct 19, 2020
@sindresorhus sindresorhus merged commit b1afa2b into sindresorhus:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

got.stream.delete returns writable
2 participants
@toondaey @sindresorhus