Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic argument to AfterResponseHook TypeScript type #1589

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Add generic argument to AfterResponseHook TypeScript type #1589

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4a4384
feat: add generic to AfterResponseHook
Jan 22, 2021
325fc82
chore: rename generic type
Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/as-promise/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export interface PaginationOptions<T, R> {
};
}

export type AfterResponseHook = (response: Response, retryWithMergedOptions: (options: Options) => CancelableRequest<Response>) => Response | CancelableRequest<Response> | Promise<Response | CancelableRequest<Response>>;
export type AfterResponseHook<TResp = unknown> = (response: Response<TResp>, retryWithMergedOptions: (options: Options) => CancelableRequest<Response>) => Response | CancelableRequest<Response> | Promise<Response | CancelableRequest<Response>>;
filipesmedeiros marked this conversation as resolved.
Show resolved Hide resolved

// These should be merged into Options in core/index.ts
export namespace PromiseOnly {
Expand Down