Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize timeouts and generally improve the whole thing #534

Merged
merged 7 commits into from
Jul 25, 2018
Merged

Customize timeouts and generally improve the whole thing #534

merged 7 commits into from
Jul 25, 2018

Commits on Jul 23, 2018

  1. feat: add timeouts for lookup and response events 

    - Refactor timed-out to optimistically defer errors until after the poll
  phase of the current event loop tick.
- Timeouts begin and end when their respective phase of the lifecycle
  begins and ends.
- Timeouts result in a `got.TimeoutError`
    Jonathan Stewmon committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    4bcbb3b View commit details
    Browse the repository at this point in the history

  2. fix: hardcode ipv4 loopback address in tests to appease travis-ci 

    https://docs.travis-ci.com/user/reference/precise/#Networking
    Jonathan Stewmon committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    0ff85f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2018

  1. fix: response timer should start when request has been written to the… 

    … socket
    Jonathan Stewmon committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    a8bee05 View commit details
    Browse the repository at this point in the history

  2. fix: remove connect timeout from retry tests to mitigate false-negatives

    Jonathan Stewmon committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    e54cc20 View commit details
    Browse the repository at this point in the history

  3. feat: add send timeout

    Jonathan Stewmon committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    77a96c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2018

  1. fix: response timer should cancel on response 

    - add response timeout tests for slow upload and download
- add send test with keepalive
- increase timeouts to mitigate intermittent false negatives
    Jonathan Stewmon committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    0975372 View commit details
    Browse the repository at this point in the history

  2. Update readme.md

    @sindresorhus
    sindresorhus authored Jul 25, 2018
    Configuration menu
    Copy the full SHA
    caae921 View commit details
    Browse the repository at this point in the history