correctly strip www from filename - fixes #70

sindresorhus · Apr 3, 2014 · f9613f8 · f9613f8
1 parent 88a7840
commit f9613f8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -41,11 +41,8 @@ function generateSizes(url, size, opts) {
  url = url.replace(/^localhost/, 'http://$&');
  url = urlMod.parse(url).protocol ? url : 'http://' + url;
 
- // strip `www.`
- url = url.replace(/^(?:https?:\/\/)?www\./, '');
-
  // make it a valid filename
- var filenameUrl = slugifyUrl(url);
+ var filenameUrl = slugifyUrl(url).replace(/^(?:https?:\/\/)?www\./, '');
 
  var filename = filenameUrl + '-' + size + '.png';
  var dim = size.split(/x/i);

diff --git a/test.js b/test.js
@@ -35,7 +35,7 @@ it('should generate screenshots', function (cb) {
 
 it('should remove special characters from the URL to create a valid filename', function (cb) {
  var items =[{
- url: 'http://microsoft.com/?query=pageres*|<>:"\\',
+ url: 'http://www.microsoft.com/?query=pageres*|<>:"\\',
  sizes: '1024x768'
  }];