Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture a specific DOM element #100

Closed
sindresorhus opened this issue Aug 11, 2014 · 5 comments
Closed

Capture a specific DOM element #100

sindresorhus opened this issue Aug 11, 2014 · 5 comments

Comments

@sindresorhus
Copy link
Owner

Using a selector.

Something like: http://stackoverflow.com/a/11917107/64949

@kevva
Copy link
Contributor

kevva commented Aug 14, 2014

How is this best implemented? --selector/element? Or as a keyword maybe?

@sindresorhus
Copy link
Owner Author

I was thinking --selector '.foo > a. You would still want to specify the size in case the size of the element selected is dependent on the viewport size. .selector() in the API sounds good to me.

@kevva
Copy link
Contributor

kevva commented Aug 14, 2014

I removed the .selector() part. That wouldn't work for multiple sources. We'd have to add some options to the .src() method to make that work. Like .src('yeoman.io, ['1280x1024', '1920x1080'], { selector: '.foo > a' });.

A .selector() method would've been the cleanest solution though :/.

@sindresorhus
Copy link
Owner Author

Ah, yeah. That works too though.

@kevva
Copy link
Contributor

kevva commented Aug 14, 2014

Alright, I'll have a go at it then.

@sindresorhus sindresorhus added this to the 0.5.0 milestone Aug 17, 2014
@kevva kevva closed this as completed in 41b818e Aug 18, 2014
kevva added a commit that referenced this issue Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants