Use fs-write-stream-atomic

[sindresorhus]

Currently we leave behind corrupt files if the process somewhat fails, this would prevent it.

https:/npm/fs-write-stream-atomic

[kevva]

+1

[sindresorhus]

Still not optimal. It now prevents race conflicts, but if the process exits early (eg. by the user force exiting) the temp file is left in place: todomvc.com-1000x1000.png.236b1396348943e83e939985535b221e.

It should probably be cleaned up.

@kevva Would it make sense to open a feature request on that module?

[kevva]

Does it matter if it's written to the temp dir though? But if it's fixable I don't see why they shouldn't do it. Might as well open a request.

[sindresorhus]

It's written to the cwd, not a temp dir. Try Ctrl+C a pageres session.

[kevva]

Oh, they should at least write it to /tmp imo. I'll open an issue.

[sindresorhus]

Wanna open a ticket there?

[kevva]

Yup, npm/fs-write-stream-atomic#1.

[sindresorhus]

I guess we could do it manually in our package by removing this.__atomicTmp on process.exit or process.SIGINT.

Let's do that for now. I don't see them fixing it in the near-term.

[kevva]

Hm, I tried to do this, but each-async freaks out because next is called multiple times since writeStreamAtomic will emit errors when the process is canceled.

[sindresorhus]

https:/sindresorhus/onetime

[kevva]

Yeah, but how do we circumvent it nicely? Calling cb instead of next works or by stop listening for errors on the writeStream (which is not ideal). I tried checking the error code for ENOENT and only calling cb when true but that didn't work for some weird reason.

[sindresorhus]

We use onetime to only care about the first error received.