Add concurrency to image creation

[shannonrothe]

Noticed the comment so utilised Promise.all() to add concurrency to image creation 👍🏼

[sindresorhus]

I don't think Puppeteer can handle a load like this. I think you need to use https:/sindresorhus/p-all with a concurrency of maybe "number of CPUs * 2". Needs to be tested what gives the output performance.

[shannonrothe]

@sindresorhus no problem, I might look into this a bit more when I get a chance 👍

[sindresorhus]

Friendly bump :)

[shannonrothe]

@sindresorhus still failing tests, not sure what the issue is with p-all 😕 Please check my changes and let me know how we can best approach 👍🏼

[sindresorhus]

You are using p-all incorrectly, which the error also points out.

[sindresorhus]

It might be better to use p-map since you're mapping this.sizes.

[shannonrothe]

It might be better to use p-map since you're mapping this.sizes.

Done, should be okay now 👌🏼

[sindresorhus]

This is not very readable. Make it a variable and then in a new statement, you can use destructuring instead of "push".

[sindresorhus]

Thanks :)