Conditionally add node/DOM types to StructuredCloneable #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #899, I discovered a solution that lets us only include DOM/Node types if they actually exist. Based on this code from the node type declarations, I came up with this solution:
This only works with types that have a public constructor in
globalThis
, butBlob
,File
, and all the DOM types appear to have constructors and work like this. In order to verify that all the DOM types have public constructors I added@webgpu/types
,@types/dom-webcodecs
, and@types/webxr
, which got me most of the types I was missing, then I created this file to manually check them:Fixes #899