-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed upload creates "shadow" container image #388
Comments
I’m aware of this bug- the reason it happens is because we don’t know the name, tag etc until the last step and then we rename and show in the collection. It should not, however, interfere with deleting a collection, although it will show it to exist. If you have a suggested fix that resolves the issue you are seeing I’m happy to review a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When there is only slightly more space left on the registry host than a image upload would need, the upload fails with HTTP error 500 (internal server error). The problem is, that even though the upload fails, a "logical" / shadow image remains. This shadow image is then part of a collection and seems to reference an actual image file that is not present. Therefore:
delete_minio_container
in minio.py) even though there are no real references left but the shadow images resulting from the bugTo Reproduce
For example: we have 212MB of storage left and upload a 161MB image that hasn't been previously uploaded. An image object is created in sregistry to represent the image file in collections, etc. The upload finishes with 100% done, but nonetheless an error message is appearing with HTTP 500. All the space is used up on the MinIO storage (guess due to MinIO data safety mechanisms needing more space than just the image size?). The image only appears in the collection overview, but not inside the collection. If we start the upload again, it fails instantly but still a shadow image is created and remains.
Expected behavior
The text was updated successfully, but these errors were encountered: