Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to filter analisys based on Maven package #100

Merged
merged 2 commits into from
Dec 21, 2015

Conversation

LasneF
Copy link
Contributor

@LasneF LasneF commented Dec 21, 2015

this is done for instance ear , package
in my own project we have set a dedicated packaging for public api

@siom79 this feature could be merged with the skipPom ( currently not done to avoid breaking changes)

@siom79 siom79 merged commit bbdab63 into siom79:develop Dec 21, 2015
siom79 added a commit that referenced this pull request Dec 21, 2015
…sary empty lines in methods, added curly braces for if clauses, added documentation, added (integration) test (new maven module ).
@siom79
Copy link
Owner

siom79 commented Dec 21, 2015

@LasneF Thank you for providing this pull request. I have just merged it on the develop branch.

I have modified a few things:

  • Moved the new parameter to the <parameter/> section of the <configuration/>.
  • Removed unnecessary empty lines in methods.
  • Added curly braces for if clauses.
  • Added documentation.
  • Added (integration) test (new maven module japicmp-test-maven-plugin-packaging).

siom79 added a commit that referenced this pull request Dec 21, 2015
@siom79
Copy link
Owner

siom79 commented Dec 21, 2015

And added you to the <contributors/> section of the pom.xml 😉

@LasneF LasneF deleted the feature/filterPackaging branch December 22, 2015 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants