Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generateRandomString #223

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Fix generateRandomString #223

merged 2 commits into from
Feb 24, 2023

Conversation

sivertschou
Copy link
Owner

@sivertschou sivertschou commented Feb 24, 2023

.substr got replaced by .substring during the Granka-scrappening in November (#193), due to .substr being officially deprecated. This was obviously not tested thoroughly enough, and lead to weird room ids 🫣

Also; bumped creyD/prettier_action to v4.3 to avoid a bug. (and formatted the action file :^)))

Before After
image image

@sivertschou sivertschou force-pushed the fix-random-stinrg-generator branch 2 times, most recently from 248f59e to d672a55 Compare February 24, 2023 21:29
Copy link
Collaborator

@morteako morteako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Good fix! 🪨 🚀

@sivertschou sivertschou merged commit e63aa8b into master Feb 24, 2023
@sivertschou sivertschou deleted the fix-random-stinrg-generator branch February 24, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants