-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Design Token system #553
Comments
NOTE: I have modified the |
NOTE: |
I've got MOST existing styles flushed out, just need to run through and documented. I think we should handle applying these to various elements and components in a dedicated pass. Either at the tail end of this PR or separate one. |
This is now ready to review per this PR: Here's a preview link: |
Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!
The initial draft of the design token system has been a huge hit and very well received. However, we would stand to make some significant improvements to make it even better.
This includes, but is not limited to the following:
on-{x}
color system for text and icon fill colors when overlaid in buttons, etcon-{x}
propertiesWhat type of pull request would this be?
Enhancement
Any links to similar examples or other references we should review?
Material Design has some references we can follow:
This may be one of the final updates required to close out:
The text was updated successfully, but these errors were encountered: