Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: "Added a !no-underline class to prevent text underlines" #983

Closed
alexander-mart opened this issue Feb 18, 2023 · 4 comments
Closed
Labels
documentation Improvements or additions to documentation

Comments

@alexander-mart
Copy link

Link to the Page

https://www.skeleton.dev/docs/comparisons

Describe the Issue

- Added a !no-outline class to prevent text underlines.
+ Added a !no-underline class to prevent text underlines.

Are you able to create a Pull Request with the fix?

Yes

@alexander-mart alexander-mart added the documentation Improvements or additions to documentation label Feb 18, 2023
@alexander-mart alexander-mart changed the title <title> docs: "Added a !no-underline class to prevent text underlines" Feb 18, 2023
@endigo9740
Copy link
Contributor

@alexander-mart can you expand on your issue here? You link to the comparison page but I see no relevance to what you're describing. In fact I can find no instance of no-outline in the entirety of the Skeleton project.

@alexander-mart
Copy link
Author

@endigo9740 It's inside the spoiler: View Flowbite integration mini-guide.

@alexander-mart
Copy link
Author

@endigo9740 I'm assuming the documentation pages haven't been published to github yet.

@endigo9740
Copy link
Contributor

endigo9740 commented Feb 19, 2023

Ahh I see, you're checking against production branch, but this section has been moved and modified on dev branch and is no longer present. That's why I could not find this. The updated section now links directly to our blog post detailing full integration instructions with Flowbite:
https://dev.skeleton.dev/docs/introduction

Expect to see this version of the docs drop with our standard release cycle on Tuesday of this week (US time)

The library and documentations are a combined project within this repository. You can find this new page here:
https:/skeletonlabs/skeleton/blob/dev/src/routes/(inner)/docs/introduction/%2Bpage.svelte#L132

Also be aware we're right in the midst of a major documentation overhaul. A lot of info will be tweaked, adjusted, moved, and various visual changes implemented. You can follow along here:
#783

For now the suggested change is no longer relevant, so I'm going to go ahead and close this out. Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants