bugfix: scroll to top of modal, when modal is bigger than view

[Mahmoud-zino]

Linked Issue

Closes #1683

Description

Fixed the bug using the code suggestion

Changsets

bugfix: fixed Scroll to the top of the modal, when the modal is bigger than the view.

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

🦋 Changeset detected

Latest commit: 1f00268

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@skeletonlabs/skeleton	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	Jul 7, 2023 5:36pm

[endigo9740]

@Mahmoud-zino I think I mentioned this on Discord previously, but just so it's echoed here - I'd like to revisit the styling on this. I believe this is how we had the component styled previously and it introduced some issue for modals that were meant to fill the available screen space.

We may need to introduce a toggle or setting for this. I'll revisit asap.

[Mahmoud-zino]

@endigo9740 In the meantime I will do some testing 👍

[endigo9740]

@Mahmoud-zino I'm reverting this back to Draft until I can make my changes. This will likely occur next week after the next release.

[endigo9740]

@Mahmoud-zino after reviewing this again with a fresh set of eyes I think your changes will work for now. I do still have some concerns for edge cases, but for the majority of users this will likely work as desired. We'll monitor and if issues arise we'll revisit.