Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/input-chip-add-remove-manually #2347

Merged

Conversation

Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #2293

Description

implemented exported functions add/remove chip to manually add-remove chip.

@endigo9740

  1. I know we have a feat freeze, but I think even if we had to rewrite the implemented function, they can serve as a base for the rewrite.
  2. I refactored the existing functions to make them easier to read and debug, but feel free to revert anything you don't agree with.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

vercel bot commented Dec 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jan 29, 2024 6:02pm

Copy link

changeset-bot bot commented Dec 23, 2023

🦋 Changeset detected

Latest commit: 4960690

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endigo9740
Copy link
Contributor

@Mahmoud-zino I somehow completely missed this, so I'll plan to review and merge between now and the next release. My bad!

@endigo9740
Copy link
Contributor

@Mahmoud-zino I haven't forgot your PR here, just been too swamped to devote proper time to it. I hope to rectify that soon. I do think we'll move forward with this if I can confirm all is well.

@endigo9740
Copy link
Contributor

endigo9740 commented Jan 29, 2024

@Mahmoud-zino just had a look at this. The functionality is great! Just a couple minor things:

  1. I'm seeing this warning when I started the CLI locally.
11:32:17 AM [vite-plugin-svelte] /Users/chris/Development/skeleton/skeleton/packages/skeleton/src/lib/components/InputChip/InputChip.svelte:36:11 InputChip has unused export property 'chipTransitionIn'. If it is for external reference only, please consider using `export const chipTransitionIn`

Screenshot 2024-01-29 at 11 32 32 AM

2 Additionally, per the documentation, instead of saying "manually" here, can we say "programmatically" please?

Screenshot 2024-01-29 at 11 33 38 AM

@endigo9740
Copy link
Contributor

endigo9740 commented Jan 29, 2024

@Mahmoud-zino one more thing....can you make the numbers random values between say 1-10,000? I think it'll look nicer than the decimal values. But super nitpicky, don't stress about it you don't have time. We can evaluate again when we port to v3.

Screenshot 2024-01-29 at 11 40 57 AM

@endigo9740
Copy link
Contributor

@Mahmoud-zino perfect, thanks!

@endigo9740 endigo9740 merged commit 69b6825 into skeletonlabs:dev Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Props not working as expected on InputChip & AutoComplete combination
2 participants