Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested keys with tableSourceMapper #2460

Closed

Conversation

chrispump
Copy link

@chrispump chrispump commented Feb 2, 2024

Linked Issue

Closes #2459

Description

Adds the ability to use nested keys in tableSourceMapper

Changsets

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 902650c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Feb 2, 2024 1:18am

@endigo9740
Copy link
Contributor

endigo9740 commented Feb 9, 2024

@chrispump I think you were already in-progress on this before I had a chance to comment in the original post:

However, I think for now we'll skip this. I will, however, keep this in consideration for v3. Just FYI in v3 we're going to go all in on native HTML table styled with our Table element styles:

https://skeleton-next-git-next-skeleton-labs.vercel.app/tailwind/tables

This will be paired with detailed integration guides for at least one datatable solution per framework. For Svelte, this will likely be an evolution of this new v2 guide, which should release next week:

If you haven't already, I'd consider moving away from the table mapper function and handling this directly, and/or moving to the native HTML table approach. This will better prepare you for the future.

Thanks for the contribution all the same though!

@endigo9740 endigo9740 closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested keys with tableSourceMapper
2 participants