Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to Meteor v1.7 #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JonathanLehner
Copy link

I upgraded to Meteor v1.7 and fixed the resulting errors. Would be cool if you could look at the handling of "build-extras.gradle", which seems necessary to make it compile.

@skishore
Copy link
Owner

Hey, thanks for doing that!

The reason I've been holding off on updating Meteor here is that it necessitates updates throughout the toolchain - I would need to install a new Android SDK, a new version of Xcode, etc. There's a forced upgrade coming in a couple of months, so I was just going to do it then.

Have you built this version on both Android and iOS?

@JonathanLehner
Copy link
Author

hi Shaunak!
Sorry for my late reply.
I tested both Android and IOS. You have to be a bit careful with cordova versions and android sdk though, since these seem to be relevant for build success. The appropriate cordova version should be set in the updated package.json file. There might be some gradle issues, so for me to build I had to add build-extras.gradle (see files) to .meteor/local/cordova-build/platforms/android/
With that it builds successfully on both Android and IOS. I tested it again just now.

If you have any issues with building feel free to let me know!

Best wishes,
Jonathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants