refactor(CA2208): rather, catch the invalid enum value in ctor.

skwasjer · Nov 18, 2023 · 5702763 · 5702763
1 parent 1770c62
commit 5702763
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/MockHttp/Http/HttpHeaderEqualityComparer.cs b/src/MockHttp/Http/HttpHeaderEqualityComparer.cs
@@ -1,4 +1,5 @@
-using MockHttp.Matchers.Patterns;
+using System.ComponentModel;
+using MockHttp.Matchers.Patterns;
 
 namespace MockHttp.Http;
 
@@ -25,6 +26,11 @@ internal sealed class HttpHeaderEqualityComparer : IEqualityComparer<KeyValuePai
 
  public HttpHeaderEqualityComparer(HttpHeaderMatchType matchType)
  {
+ if (!Enum.IsDefined(typeof(HttpHeaderMatchType), matchType))
+ {
+ throw new InvalidEnumArgumentException(nameof(matchType), (int)matchType, typeof(HttpHeaderMatchType));
+ }
+
  _matchType = matchType;
  }
 
@@ -67,7 +73,7 @@ public bool Equals(KeyValuePair<string, IEnumerable<string>> x, KeyValuePair<str
  return !x.Value.Any();
  }
  default:
- throw new ArgumentOutOfRangeException();
+ return false;
  }
  }