refactor: replaced RequestUriMatcher with UriMatcher #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skwasjer
force-pushed
the
feature/uri_matching
branch
from
14646b8
to
82639da
Compare
skwasjer
force-pushed
the
feature/uri_matching
branch
from
82639da
to
c5ca29c
Compare
skwasjer
force-pushed
the
feature/uri_matching
branch
from
c5ca29c
to
a63b495
Compare
…her types of matchers that check portions of the URI, like path/route values, etc.
…dded option to disable wildcards on request URI matching.
skwasjer
force-pushed
the
feature/uri_matching
branch
from
a63b495
to
91a6fbb
Compare
|
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
RequestUriMatcherintoUriMatcher. The latter is easily reusable to add additional future matchers for (parts of) URI's, for example to match only the path, host, port, scheme (etc). Moved the (original) test coverage accordingly to the extension test fixture.I also added the
allowWildcardsoptional parameter to theRequestUri()extension method (default true, as this was internally already the default), to allow full coverage to carry over.Functionally, it still behaves identical and the public API has not changed otherwise except for the aforementioned extension.