Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address several static code analysis warnings #84

Merged
merged 12 commits into from
Nov 18, 2023
Merged

Address several static code analysis warnings #84

merged 12 commits into from
Nov 18, 2023

Conversation

skwasjer
Copy link
Owner

@skwasjer skwasjer commented Nov 18, 2023

  • fix(CA2007): ConfigureAwait the task
  • style(CA1819): properties should not return arrays
  • style(CA1037): overload accepting StringComparison
  • style(CA8602): suppress dereference possible null
  • style(CA2000): suppress because it is registered for dispose
  • style(CA2201): suppress
  • style(CA1859): change interface type to concrete type for perf.
  • style(CA1054,CA1056): change type of parameter from string to Uri.
    • The MockHttpServer.HostUrl is deprecated. Use MockHttpServer.HostUri instead.
    • The MockHttpServer ctors accepting string URL's are deprecated. Use the overloads accepting System.Uri.
  • style(CA1861): prefer 'static readonly' fields over constant array args.
  • style(CA1860): prefer comparing count to 0 rather using Any()
  • style(CA5394): do not use insecure randomness
  • style(CA1307,CA1309): Use ordinal string comparison

Copy link

sonarcloud bot commented Nov 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

92.7% 92.7% Coverage
0.0% 0.0% Duplication

@skwasjer skwasjer enabled auto-merge (squash) November 18, 2023 02:26
@skwasjer skwasjer enabled auto-merge (squash) November 18, 2023 02:28
@skwasjer skwasjer merged commit 038adaa into main Nov 18, 2023
13 checks passed
@skwasjer skwasjer deleted the fix/sca branch November 18, 2023 02:57
@skwasjer skwasjer added the enhancement New feature or request label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant