Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address some static code analysis issues, exposed by the latest analyzer #87

Merged
merged 5 commits into from
Nov 18, 2023

Conversation

skwasjer
Copy link
Owner

  • refactor(CA2208): throw invalid enum exception in ctor to satisfy static code analysis.
  • fix(SYSLIB0051): mark serializable/binary formatter support as obsolete
  • refactor(CA1031): use TryAddWithoutValidation to avoid exceptions and to skip adding header if not supported.
  • fix(CA2007): use ConfigureAwait on awaitable async stream
  • test(CS8604): in older runtimes, IEqualityComparer<> did not use nullable annotation. Fix with string polyfill for Arg.Any.

Copy link

sonarcloud bot commented Nov 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@skwasjer skwasjer merged commit 6e2fdb9 into main Nov 18, 2023
12 of 13 checks passed
@skwasjer skwasjer deleted the chore/sca branch November 18, 2023 20:25
@skwasjer skwasjer added the enhancement New feature or request label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant