-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logic error in history module when transforming undo/redo against non-user changes #2105
Comments
Written a test to show this - will make a PR to fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using history module, if an edit comes in not from the user it goes through the transform. There is an error in the logic where the change that comes in is directly applied to all undos/redos. Issue is that the state between these are different. What it needs to be transformed against is the change after it's been transformed against all previous undos.
Expected behavior:
Actual behavior:
Version:
1.3.6
The text was updated successfully, but these errors were encountered: