Move drag blocking to Scroll
#2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, consumers cannot enable drag events within the editor, because they're all disabled by the `Quill` constructor registering an anonymous `dragstart` handler. This change allows consumers to override this behaviour by moving this listener to the `Scroll` blot, where the `dragstart` is prevented in a named method, which can be overridden by extending the class.
|
Great thanks! |
|
@alecgibson @jhchen I have overrided this method and allowed to d&d, but while dragging caret dissapears. |
|
It's potentially because the editor is losing focus during the drag? Maybe also related to |
|
The reason could also be that you called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, consumers cannot enable drag events within the editor,
because they're all disabled by the
Quillconstructor registering ananonymous
dragstarthandler.This change allows consumers to override this behaviour by moving this
listener to the
Scrollblot, where thedragstartis prevented in anamed method, which can be overridden by extending the class.