Fix insert inline embed with delete before block embed #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix requires the delta to explicitly specify the implicit newline that gets added as part of the new block container that the inline embed is created inside. If not explicitly specified, the internal index tracking will be off by one and the delete will consume the implict newline instead.
|
@jhchen |
|
Sorry took a while to review but looks all correct -- thank you for the PR |
DokaRus
pushed a commit
to DokaRus/devextreme-quill
that referenced
this pull request
Oct 28, 2021
…-block-embed-with-delete Fix insert inline embed with delete before block embed (cherry picked from commit 58b1747)
DokaRus
added a commit
to DevExpress/devextreme-quill
that referenced
this pull request
Oct 29, 2021
* Merge pull request slab#2882 from tzyl/fix/insert-inline-embed-before-block-embed-with-delete Fix insert inline embed with delete before block embed (cherry picked from commit 58b1747) * use Op.length (cherry picked from commit 738a196) * add failing tests (cherry picked from commit a02978f) * track all implicit newline indexes and shift for delete (cherry picked from commit cf101f6) * add test for tracking indexes between insert/delete (cherry picked from commit 50dbbed) * add fix and failing test for implicit newline insertion (cherry picked from commit 99bfdcd) * fix linter (cherry picked from commit 7e98bc2) * prefer file over html when uploading - file should include the image data - copying image from slack will include both, but image src is inaccessible without login (cherry picked from commit e164f12) * fix mixed html/file test and handle image only case (cherry picked from commit ead3355) * fix formatting * tiny refactoring Co-authored-by: Jason Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2874
This fix requires the delta to explicitly specify the implicit newline that gets added as part of the new block container that the inline embed is created inside. If not explicitly specified, the internal index tracking will be off by one and the delete will consume the implicit newline instead. (which is the current behaviour)