Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Tab handling in code block #3593

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Improve Tab handling in code block #3593

merged 1 commit into from
Jun 10, 2022

Conversation

luin
Copy link
Member

@luin luin commented Jun 8, 2022

Until this change, the Tab key always indented selected lines. However, it's more common for code editors to insert tab char with collapsed selection.

To test:

  1. When the selection is collapsed, Tab should insert CodeBlock.TAB.
  2. With the shift key pressed, Tab should always reduce indention.
  3. Otherwise it should keep the current behavior.

@luin luin requested a review from jhchen June 8, 2022 05:56
@jhchen jhchen merged commit fdaa793 into develop Jun 10, 2022
@jhchen jhchen deleted the zh-code-block-tab branch June 10, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhchen jhchen Awaiting requested review from jhchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luin @jhchen