Support paste and match style #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luin can you help take a look? |
|
@fnlctrl Sorry for the delay! Was on a vacation and forgot it. I think the idea generally makes sense and will take a look soon. |
alecgibson
added a commit
to reedsy/quill
that referenced
this pull request
Feb 9, 2024
This is a reimplementation of slab#3530 At the moment, if the clipboard pastes `text/plain` content and no `text/html` content, the `Clipboard.convert()` function will completely skip the matching logic. This is surprising when registering text node clipboard matchers. This change updates the `convert()` function to match the plain text against the plain text matchers, just like we do with HTML. Note that these matchers will run _before_ applying the formats for ["paste and match style"][1], so they won't match an element matchers for the target formatting (which I think should be expected anyway). [1]: slab#3927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most browsers/editors have a paste option "Paste and match style" or "Paste as plain text". When it's triggered, the clipboard data only contains "text/plain" and no "text/html", and editors would use the style at the cursor for the pasted text.
Currently it's not working in quill because
formatsisn't used innew Delta().insert(text)fortext/plain. This PR adds support for it.Chrome
Google Docs
