Add endpoints for calls.*
apis and Type: call
in blockkit
#1190
+444
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the API methods for the Calls API in Slack https://api.slack.com/apis/calls
Implemented methods
calls.add
- Indicate a new call has been startedcalls.end
- Indicate to slack that the call has endedcalls.info
- Get information about an ongoing slack call objectcalls.update
- update call informationcalls.participants.add
calls.participants.remove
Additionally, I've added the minimal version of
Block{Type: "call", CallID: string}
which slack recommends/requires be posted back to the channel https://api.slack.com/apis/calls#post_to_channel.All implemented functionality is publicly documented. There appear to be additional attributes on the
type: call
block, however those appear to be internal values for slack's rendering, so I have left them out. See this gist for specific responses https://gist.github.com/winston-stripe/0cac608bd63b42d73a352be53577f7fdPull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prep
from the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: