-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: slice replace loop #1211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzoaiello
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @testwill !
Non-functional change that simplifies the code. A quick glance through the codebase shows that there may be other instances of this that can also be cleaned up, but this is a good start.
renovate bot
referenced
this pull request
in validator-labs/validator
Jul 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/slack-go/slack](https://togithub.com/slack-go/slack) | `v0.13.0` -> `v0.13.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>slack-go/slack (github.com/slack-go/slack)</summary> ### [`v0.13.1`](https://togithub.com/slack-go/slack/releases/tag/v0.13.1) [Compare Source](https://togithub.com/slack-go/slack/compare/v0.13.0...v0.13.1) #### What's Changed v0.13.1 is now available. It contains **no breaking changes** but does expose some new fields previously unavailable. ##### Enhancements - Added `UnfurlLinks` and `UnfurlMedia` to `WebhookMessage` by [@​lheiskan](https://togithub.com/lheiskan) in [https:/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - Added `isReadOnly` property to `Conversation` struct by [@​GGonryun](https://togithub.com/GGonryun) in [https:/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) ##### Bug Fixes - Fixed `UploadFileV2` when using text content by [@​calebmckay](https://togithub.com/calebmckay) in [https:/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - Made `Channel` optional on `UploadFileV2` by [@​0xdeafcafe](https://togithub.com/0xdeafcafe) in [https:/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) ##### Chores / Code Cleanup - Replace a Loop with Slice by [@​testwill](https://togithub.com/testwill) in [https:/slack-go/slack/pull/1211](https://togithub.com/slack-go/slack/pull/1211) - Added Deprecation Notice for `files.upload` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - Added Go Test Coverage for 1.21 and 1.22 by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1298](https://togithub.com/slack-go/slack/pull/1298) ##### Documentation Updates - Updated Inline Docs and API References by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1299](https://togithub.com/slack-go/slack/pull/1299) - Added an example for `Pagination` by [@​adamrothman](https://togithub.com/adamrothman) in [https:/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) - Added an example for `ConversationHistory` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1302](https://togithub.com/slack-go/slack/pull/1302) - Added an example for `AddRemoteFile` and `DeleteFile` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1303](https://togithub.com/slack-go/slack/pull/1303) #### New Contributors - [@​calebmckay](https://togithub.com/calebmckay) made their first contribution in [https:/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - [@​lheiskan](https://togithub.com/lheiskan) made their first contribution in [https:/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - [@​GGonryun](https://togithub.com/GGonryun) made their first contribution in [https:/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) - [@​0xdeafcafe](https://togithub.com/0xdeafcafe) made their first contribution in [https:/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) - [@​lorenzoaiello](https://togithub.com/lorenzoaiello) made their first contribution in [https:/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - [@​adamrothman](https://togithub.com/adamrothman) made their first contribution in [https:/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) **Full Changelog**: slack-go/slack@v0.13.0...v0.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnbyJdfQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ymotongpoo
referenced
this pull request
in ymotongpoo/opentelemetry-collector-extra
Aug 13, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/slack-go/slack](https://togithub.com/slack-go/slack) | `v0.13.0` -> `v0.13.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fslack-go%2fslack/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fslack-go%2fslack/v0.13.0/v0.13.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>slack-go/slack (github.com/slack-go/slack)</summary> ### [`v0.13.1`](https://togithub.com/slack-go/slack/releases/tag/v0.13.1) [Compare Source](https://togithub.com/slack-go/slack/compare/v0.13.0...v0.13.1) #### What's Changed v0.13.1 is now available. It contains **no breaking changes** but does expose some new fields previously unavailable. ##### Enhancements - Added `UnfurlLinks` and `UnfurlMedia` to `WebhookMessage` by [@​lheiskan](https://togithub.com/lheiskan) in [https:/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - Added `isReadOnly` property to `Conversation` struct by [@​GGonryun](https://togithub.com/GGonryun) in [https:/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) ##### Bug Fixes - Fixed `UploadFileV2` when using text content by [@​calebmckay](https://togithub.com/calebmckay) in [https:/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - Made `Channel` optional on `UploadFileV2` by [@​0xdeafcafe](https://togithub.com/0xdeafcafe) in [https:/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) ##### Chores / Code Cleanup - Replace a Loop with Slice by [@​testwill](https://togithub.com/testwill) in [https:/slack-go/slack/pull/1211](https://togithub.com/slack-go/slack/pull/1211) - Added Deprecation Notice for `files.upload` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - Added Go Test Coverage for 1.21 and 1.22 by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1298](https://togithub.com/slack-go/slack/pull/1298) ##### Documentation Updates - Updated Inline Docs and API References by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1299](https://togithub.com/slack-go/slack/pull/1299) - Added an example for `Pagination` by [@​adamrothman](https://togithub.com/adamrothman) in [https:/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) - Added an example for `ConversationHistory` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1302](https://togithub.com/slack-go/slack/pull/1302) - Added an example for `AddRemoteFile` and `DeleteFile` by [@​lorenzoaiello](https://togithub.com/lorenzoaiello) in [https:/slack-go/slack/pull/1303](https://togithub.com/slack-go/slack/pull/1303) #### New Contributors - [@​calebmckay](https://togithub.com/calebmckay) made their first contribution in [https:/slack-go/slack/pull/1291](https://togithub.com/slack-go/slack/pull/1291) - [@​lheiskan](https://togithub.com/lheiskan) made their first contribution in [https:/slack-go/slack/pull/1208](https://togithub.com/slack-go/slack/pull/1208) - [@​GGonryun](https://togithub.com/GGonryun) made their first contribution in [https:/slack-go/slack/pull/1232](https://togithub.com/slack-go/slack/pull/1232) - [@​0xdeafcafe](https://togithub.com/0xdeafcafe) made their first contribution in [https:/slack-go/slack/pull/1293](https://togithub.com/slack-go/slack/pull/1293) - [@​lorenzoaiello](https://togithub.com/lorenzoaiello) made their first contribution in [https:/slack-go/slack/pull/1300](https://togithub.com/slack-go/slack/pull/1300) - [@​adamrothman](https://togithub.com/adamrothman) made their first contribution in [https:/slack-go/slack/pull/1201](https://togithub.com/slack-go/slack/pull/1201) **Full Changelog**: slack-go/slack@v0.13.0...v0.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/ymotongpoo/opentelemetry-collector-extra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.
PR preparation
Run
make pr-prep
from the root of the repository to run formatting, linting and tests.Should this be an issue instead
API changes
Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.
Examples of API changes that do not meet guidelines: