Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XGBoostCVRegressor + Dependencies with Poetry v1.2 #137

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

amirhessam88
Copy link
Member

@amirhessam88 amirhessam88 commented Sep 11, 2022

Description

  • Fixed package dependencies in pyproject.toml with poetry v1.2; The only issue is glmnet that depends on numpy.distutils to actually comple the BTS fortran code and this module is deprecated for numpy version >= 1.23; Therefore, for now we keep the numpy version < 1.23 until there is a new wheel file available for glmnet; issue already submitted.
  • Refactored XGBoostCVRegressor + added unit-tests.
  • More cleanup.

Resolves: #issue-number-here

Pull Request Checklist

  • Added tests for added or changed code.
  • Added documentation for changed code.

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #137 (bfa8e59) into master (7864f7c) will increase coverage by 2.62%.
The diff coverage is 98.24%.

❗ Current head bfa8e59 differs from pull request most recent head 4edb46c. Consider uploading reports for the commit 4edb46c to get more accurate results

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   44.16%   46.79%   +2.62%     
==========================================
  Files          20       21       +1     
  Lines        2024     2030       +6     
  Branches      388      379       -9     
==========================================
+ Hits          894      950      +56     
+ Misses       1101     1051      -50     
  Partials       29       29              
Flag Coverage Δ
unittests 46.79% <98.24%> (+2.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/slickml/classification/_xgboostcv.py 100.00% <ø> (ø)
src/slickml/regression/_todo.py 0.00% <0.00%> (ø)
src/slickml/regression/_xgboost.py 100.00% <ø> (ø)
src/slickml/regression/_xgboostcv.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amirhessam88 amirhessam88 merged commit 32e9157 into master Sep 11, 2022
@amirhessam88 amirhessam88 deleted the amir/fix-poetry branch September 11, 2022 06:45
@amirhessam88 amirhessam88 self-assigned this Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant