Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metrics in XGBoostClassifier and XGBoostRegressor #147

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

amirhessam88
Copy link
Member

@amirhessam88 amirhessam88 commented Oct 2, 2022

Description

  • Removed metrics from XGBoostClassifier and XGBoostRegressor since there is no need to have it. metrics is being used in _cv() module only and eval_metrics still can be used as a params item.
  • Updated unit-tests accoringly.
  • Update example notebooks.

TODO

Pull Request Checklist

  • Added tests for added or changed code.
  • Added documentation for changed code.

@amirhessam88 amirhessam88 self-assigned this Oct 2, 2022
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 67.53% // Head: 67.50% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (09662e5) compared to base (e16e609).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   67.53%   67.50%   -0.04%     
==========================================
  Files          22       22              
  Lines        1999     1997       -2     
  Branches      302      302              
==========================================
- Hits         1350     1348       -2     
  Misses        602      602              
  Partials       47       47              
Flag Coverage Δ
unittests 67.50% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/slickml/classification/_xgboost.py 100.00% <ø> (ø)
src/slickml/regression/_xgboost.py 100.00% <ø> (ø)
src/slickml/classification/_xgboostcv.py 100.00% <100.00%> (ø)
src/slickml/regression/_xgboostcv.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amirhessam88 amirhessam88 merged commit bc4b357 into master Oct 2, 2022
@amirhessam88 amirhessam88 deleted the amir/fix-xgb-metrics branch October 2, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant