Add pytest conftest #158
Merged
Add pytest conftest #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhessam88
commented
Oct 28, 2022
| from tests import resources | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") |
There was a problem hiding this comment.
all fixtures should have session scope.
|
|
||
|
|
||
| # TODO(amir): add lolipop plot for coeff + unit-test | ||
| # TODO(amir): add test for lambda-path param | ||
| class TestGLMNetCVClassifier: | ||
| """Validates `GLMNetCVClassifier` instantiation.""" | ||
|
|
||
| @staticmethod | ||
| @pytest.fixture(scope="module") |
There was a problem hiding this comment.
all repeated fixture codes are now removed.
| @@ -1,151 +0,0 @@ | |||
| import importlib.resources as pkg_resources | |||
There was a problem hiding this comment.
the content of utils.py are now consolidated with conftest.py.
| ids=_ids, | ||
| ) | ||
| def test_xgboostcvregressor__passes__with_defaults( | ||
| self, | ||
| reg_x_y_data: Tuple[ | ||
| reg_train_test_x_y: Tuple[ |
There was a problem hiding this comment.
standardized the naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conftest.pyand move allpytest.fixturesin it.glmnettests.test/utils.pyintoconftest.py.Resolves: #issue-number-here
Pull Request Checklist