Fix xgboost feature selector callbacks #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhessam88
commented
Oct 30, 2022
| @@ -1045,6 +1045,10 @@ def _callbacks(self) -> None: | |||
| None | |||
| """ | |||
| if self.callbacks: | |||
| # TODO(amir): ditch print with logger | |||
There was a problem hiding this comment.
I will standardize all prints with logging so0on
amirhessam88
force-pushed
the
amir/base-selector
branch
from
9935afe
to
8e94174
Compare
Codecov ReportBase: 80.43% // Head: 80.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 80.43% 80.54% +0.11%
==========================================
Files 22 22
Lines 1963 1964 +1
Branches 254 254
==========================================
+ Hits 1579 1582 +3
+ Misses 329 328 -1
+ Partials 55 54 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
warningnote thatcallbacks=Truewill break if the criterion forearly_stopping_roundwas not met.Resolves: #issue-number-here
Pull Request Checklist