Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 plugins, mypy dependencies, and poe check command #170

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

amirhessam88
Copy link
Member

Description

  • Added all needed flake8-plugins and fixed all required changes.
  • Updated .flake8 based on the new plugins.
  • Updated poe check command to be able to apply to any single .py files.
  • Updated flake8 and mypy dependencies.

Resolves: #issue-number-here

Pull Request Checklist

  • Added tests for added or changed code.
  • Added documentation for changed code.

@amirhessam88 amirhessam88 changed the title Fix flake8 plugins and mypy dependencies and poe check command Fix flake8 plugins, mypy dependencies, and poe check command Nov 27, 2022
@amirhessam88 amirhessam88 self-assigned this Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 93.73% // Head: 93.73% // No change to project coverage 👍

Coverage data is based on head (ebc4964) compared to base (eece688).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          22       22           
  Lines        1869     1869           
  Branches      204      202    -2     
=======================================
  Hits         1752     1752           
  Misses         63       63           
  Partials       54       54           
Flag Coverage Δ
unittests 93.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/slickml/classification/_glmnet.py 97.61% <ø> (ø)
src/slickml/regression/_glmnet.py 97.48% <ø> (ø)
src/slickml/visualization/_glmnet.py 68.86% <ø> (ø)
src/slickml/visualization/_selection.py 76.66% <ø> (ø)
src/slickml/visualization/_xgboost.py 78.66% <ø> (ø)
src/slickml/base/_enum.py 93.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amirhessam88 amirhessam88 merged commit 1f91289 into master Nov 27, 2022
@amirhessam88 amirhessam88 deleted the amir/flake8 branch November 27, 2022 05:38
@amirhessam88 amirhessam88 added the enhancement New feature or request label Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant