Add unit tests to cover save-path flag in all visualization modules
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhessam88
force-pushed
the
amir/fix-unit-tests
branch
from
f14321e
to
c4b8b75
Compare
amirhessam88
commented
Dec 26, 2022
| @@ -58,6 +58,9 @@ jobs: | |||
| # therefore, all the CI jobs for those python versions failed at first, then we re-run the | |||
| # jobs, the cached venv using `python v3.8` will be retrieved and the jobs will run successfully | |||
| # ideally, we should be able to add `python-versions` here to distinguish between caches | |||
| # key: venv-${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('**/poetry.lock') }} | |||
There was a problem hiding this comment.
stupid glmnet does not still let us do this!
amirhessam88
commented
Dec 26, 2022
| @@ -78,7 +78,7 @@ matplotlib = "^3.5,<3.6" | |||
| seaborn = "^0.12" | |||
|
|
|||
|
|
|||
| [tool.poetry.dev-dependencies] | |||
| [tool.poetry.group.dev.dependencies] | |||
There was a problem hiding this comment.
following new poetry syntax
amirhessam88
force-pushed
the
amir/fix-unit-tests
branch
from
c4b8b75
to
d1813e4
Compare
Codecov ReportBase: 93.39% // Head: 97.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 93.39% 97.33% +3.94%
==========================================
Files 22 22
Lines 1876 1873 -3
Branches 209 209
==========================================
+ Hits 1752 1823 +71
+ Misses 63 24 -39
+ Partials 61 26 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
save-paths.kwargsforglmnetandshap.pyproject.tomlto matchpoetry version >= 1.3.1.reviewerto @amirhessam88 in all issue templates.Resolves: #issue-number-here
Pull Request Checklist