Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add gfortran to Ubuntu install #92

Merged
merged 2 commits into from
May 31, 2022

Conversation

chadac
Copy link
Contributor

@chadac chadac commented May 31, 2022

Currently Ubuntu install when contributing fails due to a missing Fortran compiler. Suggest adding gfortran as a default.

Steps to reproduce:

docker run -it --rm -v $PWD:/app ubuntu:latest
apt-get install python3 python3-pip python3-venv build-essential
python3 -m venv /.venv
source /.venv/bin/activate
pip install poetry
cd /app
poetry install

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #92 (6814e71) into master (b0ed09d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #92   +/-   ##
======================================
  Coverage    0.24%   0.24%           
======================================
  Files          10      10           
  Lines        2047    2047           
  Branches      487     487           
======================================
  Hits            5       5           
  Misses       2042    2042           
Flag Coverage Δ
unittests 0.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ed09d...6814e71. Read the comment docs.

@amirhessam88
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants