Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor utils transform functions + unit-tests #96

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

amirhessam88
Copy link
Member

@amirhessam88 amirhessam88 commented Jun 12, 2022

  • Introduced the new layout functionality i.e. utils/_transform.py and the same for tests/.
  • Added unit-test for utils.
  • Added placeholder to start refactoring classification/ and regression.
  • Updated poe format with additional flag for add-trailing-comma.
  • Added docstring examples in utils/__init__.py

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #96 (205f21c) into master (23446d3) will increase coverage by 0.77%.
The diff coverage is 100.00%.

❗ Current head 205f21c differs from pull request most recent head 8482127. Consider uploading reports for the commit 8482127 to get more accurate results

@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
+ Coverage    0.24%   1.02%   +0.77%     
=========================================
  Files          10      10              
  Lines        2047    2054       +7     
  Branches      487     490       +3     
=========================================
+ Hits            5      21      +16     
+ Misses       2042    2033       -9     
Flag Coverage Δ
unittests 1.02% <100.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/slickml/utilities.py 0.00% <ø> (ø)
src/slickml/utils/_transform.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23446d3...8482127. Read the comment docs.

@amirhessam88 amirhessam88 force-pushed the amir/refactor-utils-transform branch from 205f21c to 7d4b0bc Compare June 12, 2022 21:19
# we eventually should be able to use it to decorate our functions and remove the validations pieces
def df_to_csr(
df: pd.DataFrame,
*,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are gonna ENFORE this from now on; to make sure named args rather positional args.

@amirhessam88 amirhessam88 force-pushed the amir/refactor-utils-transform branch from 7d4b0bc to 8482127 Compare June 12, 2022 22:52
@amirhessam88 amirhessam88 merged commit 11082a5 into master Jun 12, 2022
@amirhessam88 amirhessam88 deleted the amir/refactor-utils-transform branch June 12, 2022 22:55
@amirhessam88 amirhessam88 self-assigned this Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant