Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swik 1278 create thumbnail preview of themes #969

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pierorex
Copy link
Contributor

No description provided.

@pierorex pierorex changed the title Swik 1278 create thumbnail preview of themes WIP - Swik 1278 create thumbnail preview of themes Aug 14, 2018
@pierorex pierorex changed the title WIP - Swik 1278 create thumbnail preview of themes Swik 1278 create thumbnail preview of themes Aug 14, 2018
@kadevgraaf
Copy link
Member

kadevgraaf commented Aug 17, 2018

Hi @pierorex ! Thanks for the proposed preview solution.

It looks nice, though for usability/UX I think it might be better to have an explicit button in the pop-up carousel that says "select theme" (now you have to know that you have to click the theme (does not work in Firefox) and then click somewhere else to close the dialog)

Perhaps even better might be that the pop-up is directly shown as a component on the add-deck page (albeit a bit smaller, e.g., 100 pixels heigh and 350 pixels wide, which also shows the theme title - a bit similar to the carousel on https://glidejs.com/docs/ . This would replace both the dropdown and the button (which now seem redundant as they both say "select theme"), and in the end save several clicks for users.

Another alternative (which seems tricky to implement) would be to preview the thumbnail of a theme in a (non-clickable) pop-up/tooltip when you select it in the existing drop-down.

@pierorex
Copy link
Contributor Author

Hi @kadevgraaf, I'll totally do it as a component inside the add-deck page, I just did it as a modal because it's what the task told me to do, but I agree the other way would be much better :)

@kadevgraaf
Copy link
Member

Hi @pierorex !
Cool, thanks! 👍
Sorry for the confusion due to the task description. I hope it is not too much extra work.

@pierorex
Copy link
Contributor Author

pierorex commented Sep 4, 2018

@kadevgraaf I found a bug that I cannot solve in the component: when I save changes to a deck's theme and then enter the edit page again, the theme being shown is the old one but, if I go back to the deck page and enter again to the deck edit mode, the theme shows the updated version.

The component is added to both the add-deck and edit-deck pages.

Can someone help me understand what's happening?

@abijames
Copy link
Contributor

abijames commented Sep 7, 2018

Hi @pierorex - re the UI side of this, I will updating the deck edit and add deck UI in the next sprint as there are number of changes/additions required. Can we work on that together to get this component in correctly

@pierorex
Copy link
Contributor Author

pierorex commented Sep 7, 2018

Hi @abijames
Yes, of course we can work together. Do you mind telling me the ideas you had in mind? :)

@kprist kprist assigned kprist and unassigned kadevgraaf Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants