widgets: fixed tabs overflow behaviour #6517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloVanGH
changed the title
tronical
reviewed
Oct 11, 2024
Comment on lines
+143
to
+146
| Flickable { | ||
| HorizontalLayout { | ||
| @children | ||
| } |
There was a problem hiding this comment.
I think that this should just be a clip, not a full fledged Flickable with actual behaviour. (here and in the other files).
Suggested change
| Flickable { | |
| HorizontalLayout { | |
| @children | |
| } | |
| Rectangle { | |
| clip: true; | |
| HorizontalLayout { | |
| @children | |
| } |
There was a problem hiding this comment.
The intention is not only clipping. Then yes a Rectangle would be sufficient. What I want is to make the list of tabs scrollable when there is not enough horizontal space.
There was a problem hiding this comment.
Ah yes. It feels a bit weird to pan, but it's indeed much better than not accessible tabs at all :)
tronical
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min-widthof tabsFlickableto the tabs layoutfluentandmaterial