Add config for code rewrites #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkguts
force-pushed
the
code-rewrites
branch
from
55a6ff0
to
44dd215
Compare
emkguts
force-pushed
the
code-rewrites
branch
from
44dd215
to
32eb050
Compare
jjcarstens
requested changes
Sep 18, 2024
| @@ -174,6 +176,26 @@ defmodule Styler.Style.ConfigsTest do | |||
| ) | |||
| end | |||
|
|
|||
| test "does not reorder simple case if rewrite_if_to_unless is false" do | |||
There was a problem hiding this comment.
Suggested change
| test "does not reorder simple case if rewrite_if_to_unless is false" do | |
| test "does not reorder config files if reorder_configs is false" do |
| @@ -14,6 +14,8 @@ defmodule Styler.Style.ConfigsTest do | |||
|
|
|||
| alias Styler.Style.Configs | |||
|
|
|||
| require Logger | |||
Comment on lines
+91
to
+92
| defp maybe_exclude(list, _elem, true), do: list | ||
| defp maybe_exclude(list, elem, false), do: list -- [elem] |
There was a problem hiding this comment.
This will be fine but if there is a minute to spare, I'd suggest reviewing to see if there is a way to avoid a boolean argument. It tends to require much more tracing to understand what is going on.
Also, the value to the setting is only checked for nil when inserting which means there could be potentially be non-boolean values here which would break. If we keep this, we should remove the explicit false match
emkguts
force-pushed
the
line-length
branch
9 times, most recently
from
fdce3e5
to
da4fd4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to disable rewriting
casetoifsince it can change behavior in very rare cases. The config isinclude_case_to_if. Also allow users to disable reordering config files since it can change behavior.There is a very rare
withrewrite that could change behavior (see issue), but it is so unlikely that I'm deeming it not worth spending time on.