Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error when running tests #633

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

ezk84
Copy link
Contributor

@ezk84 ezk84 commented Oct 8, 2021

The previously merged PR #588 was based off a previous version of the code. With the changes merged in the mean time tests do not compile with the following error:

$ go test ./...
# github.com/smartystreets/goconvey/convey
$GOPATH\pkg\mod\github.com\smartystreets\goconvey@v1.6.5\convey\context.go:190:49: not enough arguments in call to reporting.NewFailureReport
        have (string)
        want (string, bool)

This resolves that problem.

@riannucci
Copy link
Collaborator

Oops, thanks; I should have checked that the base was newer :/

@riannucci riannucci merged commit 33a2c59 into smartystreets:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants