Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR bot codegen diff is broken for large diffs #1219

Closed
jdisanti opened this issue Feb 24, 2022 · 0 comments
Closed

PR bot codegen diff is broken for large diffs #1219

jdisanti opened this issue Feb 24, 2022 · 0 comments
Labels
bug Something isn't working low-priority ops Improves our operations and release process

Comments

@jdisanti
Copy link
Collaborator

Discovered in #1216, it seems like diff2html omits files from the diff when the diff is exceedingly large.

I did the following diagnosis work:

  • Modified my local codegen-diff-revisions.py script to not delete the temporary branches (here).
  • Ran the script for the changes in the PR linked above.
  • Confirmed S3 and several other services had changes in the git diff between the two temporary branches.
  • Confirmed the diff2html output did not include these files.

This issue tracks fixing the HTML output. We might need to build a tool or update an existing tool to generate a paginated HTML diff since SDK codegen diffs are always going to be huge.
@jdisanti jdisanti added bug Something isn't working ops Improves our operations and release process labels Feb 24, 2022
@jdisanti jdisanti mentioned this issue Jan 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low-priority ops Improves our operations and release process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdisanti @Velfi