Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'tslib' a runtime dependency of the package 'protoc-gen-ng' #106

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

dprogm
Copy link
Contributor

@dprogm dprogm commented Aug 13, 2023

Because packages/protoc-gen-ng/tsconfig.build.json is based on the root tsconfig.json it also inherits the flag importHelpers which requires the module tslib to be available at runtime. Therefore this dependency has been added explicitly in its dedicated package.json file.

Verification: Build the package protoc-gen-ng in isolation. This requires modification of the tsconfig files as well as the package.json. Then run npm pack and use this package locally. Without the tslib dependency the compilation fails. This isn't the case for the usual build process as the root package.json contains tslib as a dependency. This is the reason why we are getting a runtime failure.

Closes #104

@smnbbrv smnbbrv merged commit 5ff1d10 into smnbbrv:master Aug 14, 2023
@smnbbrv
Copy link
Owner

smnbbrv commented Aug 14, 2023

Thanks, is published now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running the plugin as a standalone executable throws Error: Cannot find module 'tslib'
2 participants