Make 'tslib' a runtime dependency of the package 'protoc-gen-ng' #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because packages/protoc-gen-ng/tsconfig.build.json is based on the root
tsconfig.json
it also inherits the flag importHelpers which requires the moduletslib
to be available at runtime. Therefore this dependency has been added explicitly in its dedicatedpackage.json
file.Verification: Build the package
protoc-gen-ng
in isolation. This requires modification of the tsconfig files as well as the package.json. Then runnpm pack
and use this package locally. Without thetslib
dependency the compilation fails. This isn't the case for the usual build process as the root package.json contains tslib as a dependency. This is the reason why we are getting a runtime failure.Closes #104