Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a command to search for a pattern in a file/standard input #5

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Adding a command to search for a pattern in a file/standard input #5

merged 4 commits into from
Oct 6, 2022

Conversation

kalashjain23
Copy link
Contributor

Solves #2

Quick command hints:
grep [pattern] [input] (Standard input)
grep [pattern] [file_name] -f (Finding in a file)

@smv1999
Copy link
Owner

smv1999 commented Oct 6, 2022

Your solution looks good to me @kalashjain23. But I am unable to merge because it has conflicts to be resolved. Could you please pull the remote changes first and then make your changes and push it ?

If you face any issues in this process, let me know !

@kalashjain23
Copy link
Contributor Author

Your solution looks good to me @kalashjain23. But I am unable to merge because it has conflicts to be resolved. Could you please pull the remote changes first and then make your changes and push it ?

If you face any issues in this process, let me know !

Hey! The merge conflict is now resolved!

smv1999
smv1999 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Owner

@smv1999 smv1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@smv1999 smv1999 linked an issue Oct 6, 2022 that may be closed by this pull request
Add a command to "Search for a string/pattern within a file/standard input" #2
Closed
@smv1999 smv1999 merged commit 055d481 into smv1999:main Oct 6, 2022
@smv1999
Copy link
Owner

smv1999 commented Oct 6, 2022

give @kalashjain23 150 points

@smv1999
Copy link
Owner

smv1999 commented Oct 6, 2022

Great work @kalashjain23 !!!

@kalashjain23
Copy link
Contributor Author

kalashjain23 commented Oct 6, 2022 •
edited
Loading

Great work @kalashjain23 !!!

Thank you so much, sir!!
Do we have to wait for more issues to be listed on this repo, or we can contribute on any other repo (approved by SLOP 2.0) as well?

@smv1999
Copy link
Owner

smv1999 commented Oct 6, 2022

You can create new issues on this repo and work on them too. I think you need to contact the Admin / Team of SLoP 2.0 regarding contributions to other repos.

@kalashjain23 kalashjain23 deleted the dev branch October 6, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smv1999 smv1999 smv1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a command to "Search for a string/pattern within a file/standard input"
2 participants
@kalashjain23 @smv1999