Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-270946 Progress percentage computation to handle the case when f… #628

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

sfc-gh-cshi
Copy link
Contributor

…ile size is zero

@codecov-io
Copy link

codecov-io commented Feb 17, 2021

Codecov Report

Merging #628 (9e95007) into master (23d8207) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   82.31%   82.36%   +0.04%     
==========================================
  Files          58       58              
  Lines        7358     7360       +2     
  Branches     1117     1117              
==========================================
+ Hits         6057     6062       +5     
+ Misses        980      976       -4     
- Partials      321      322       +1     
Impacted Files Coverage Δ
src/snowflake/connector/file_transfer_agent.py 74.79% <100.00%> (+0.08%) ⬆️
src/snowflake/connector/ssl_wrap_socket.py 71.21% <0.00%> (-3.04%) ⬇️
src/snowflake/connector/remote_storage_util.py 67.46% <0.00%> (-2.41%) ⬇️
src/snowflake/connector/ocsp_asn1crypto.py 79.01% <0.00%> (-1.34%) ⬇️
src/snowflake/connector/telemetry_oob.py 77.90% <0.00%> (ø)
src/snowflake/connector/ocsp_snowflake.py 72.73% <0.00%> (+0.33%) ⬆️
src/snowflake/connector/network.py 82.88% <0.00%> (+1.35%) ⬆️
src/snowflake/connector/telemetry.py 90.32% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d8207...9e95007. Read the comment docs.

test/unit/test_put_get.py Outdated Show resolved Hide resolved
src/snowflake/connector/file_transfer_agent.py Outdated Show resolved Hide resolved
@sfc-gh-cshi sfc-gh-cshi force-pushed the cshi-dev1 branch 2 times, most recently from 1831795 to 175095e Compare February 19, 2021 22:42
test/unit/test_put_get.py Outdated Show resolved Hide resolved
@sfc-gh-cshi sfc-gh-cshi force-pushed the cshi-dev1 branch 2 times, most recently from 85631dd to 9e95007 Compare February 27, 2021 00:19
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-cshi sfc-gh-cshi merged commit 74da1c5 into master Feb 27, 2021
@sfc-gh-cshi sfc-gh-cshi deleted the cshi-dev1 branch February 27, 2021 07:19
sfc-gh-aling pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants