Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1686497 Remove single buffer warning for "buffer.size.bytes" #950

Merged
merged 1 commit into from
Oct 8, 2024
Merged

SNOW-1686497 Remove single buffer warning for "buffer.size.bytes" #950

merged 1 commit into from
Oct 8, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

Overview

SNOW-1686497

When single buffering is enabled the buffer.size.bytes parameter is still passed to the ingest-sdk. Marking it as deprecated was misleading.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner October 7, 2024 14:53
@sfc-gh-mbobowski sfc-gh-mbobowski force-pushed the mbobowski-SNOW-1686497-buffer-size-log-warn branch from f1a973c to a9d8580 Compare October 7, 2024 14:55
@sfc-gh-mbobowski sfc-gh-mbobowski merged commit 946b677 into master Oct 8, 2024
78 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW-1686497-buffer-size-log-warn branch October 8, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-akowalczyk sfc-gh-akowalczyk sfc-gh-akowalczyk approved these changes

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mbobowski @sfc-gh-akowalczyk @sfc-gh-wtrefon