SNOW-1021381: Remove pkg_resource #2371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yixie
requested review from
sfc-gh-mvashishtha,
sfc-gh-jkew and
sfc-gh-jrose
sfc-gh-jrose
approved these changes
Oct 7, 2024
sfc-gh-jdu
approved these changes
Oct 7, 2024
| @@ -23,6 +23,7 @@ | |||
| "pyyaml", | |||
| "cloudpickle>=1.6.0,<=2.2.1,!=2.1.0,!=2.2.0;python_version<'3.11'", | |||
| "cloudpickle==2.2.1;python_version~='3.11'", # backend only supports cloudpickle 2.2.1 + python 3.11 at the moment | |||
| "packaging", | |||
There was a problem hiding this comment.
do we need an approval from legal team?
There was a problem hiding this comment.
we also need update in the recipe: https:/snowflakedb/snowpark-python/blob/main/recipe/meta.yaml
| Args: | ||
| name (str): The name of the package. | ||
|
|
||
| Returns: |
There was a problem hiding this comment.
nit: It looks duplicate with description, so may not needed
| package_name = package[: reg_match.start()] if reg_match else package | ||
|
|
||
| package_dict[package] = (package_name, use_local_version, package_req) | ||
| package_req = Requirement(package) |
There was a problem hiding this comment.
so it's directly handled?
sfc-gh-aling
reviewed
Oct 8, 2024
| @@ -483,14 +513,12 @@ def add_snowpark_package( | |||
| channel. | |||
|
|
|||
| Raises: | |||
| pkg_resources.DistributionNotFound: If the Snowpark Python Package is not installed in the local environment. | |||
| importlib.metadata.PackageNotFoundError: If the Snowpark Python Package is not installed in the local environment. | |||
There was a problem hiding this comment.
nit: do we need this in the change log for this error behavior change?
There was a problem hiding this comment.
This is an internal API. But we do need to check if any public APIs expose it.
sfc-gh-aling
reviewed
Oct 8, 2024
| if package.key in DEFAULT_PACKAGES: | ||
| _logger.info(f"{package.key} is available by default, ignoring...") | ||
| if package.name in DEFAULT_PACKAGES: | ||
| _logger.info(f"{package.name} is availna meble by default, ignoring...") |
There was a problem hiding this comment.
nit:
Suggested change
| _logger.info(f"{package.name} is availna meble by default, ignoring...") | |
| _logger.info(f"{package.name} is available by default, ignoring...") |
sfc-gh-aling
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1021381
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Removed pkg_resources in code. Added cod that uses importlib (a python builtin package) and packaging (from pypa).
Added packaging to the project dependency.